From cade87e93f6de0a088ee927cebb6c029cce5b698 Mon Sep 17 00:00:00 2001 From: Dnomd343 Date: Sat, 18 May 2024 23:09:18 +0800 Subject: [PATCH] update: using `std::string_view` instead of `std::string` --- src/core/common_code/common_code.h | 4 ++-- src/core/common_code/internal/common_code.inl | 4 ++-- src/core/raw_code/internal/raw_code.inl | 2 +- src/core/raw_code/raw_code.h | 2 +- src/core/short_code/internal/short_code.inl | 4 ++-- src/core/short_code/short_code.h | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/core/common_code/common_code.h b/src/core/common_code/common_code.h index 3815fcb..43d4e32 100644 --- a/src/core/common_code/common_code.h +++ b/src/core/common_code/common_code.h @@ -116,7 +116,7 @@ public: // ------------------------------------------------------------------------------------- // /// Create CommonCode from string form. - static std::optional from_string(const std::string &common_code); + static std::optional from_string(std::string_view common_code); // ------------------------------------------------------------------------------------- // @@ -135,7 +135,7 @@ public: static std::optional from_short_code(uint32_t short_code); /// Create CommonCode from ShortCode in string form. - static std::optional from_short_code(const std::string &short_code); + static std::optional from_short_code(std::string_view short_code); // ------------------------------------------------------------------------------------- // diff --git a/src/core/common_code/internal/common_code.inl b/src/core/common_code/internal/common_code.inl index 784a44f..f6b70ee 100644 --- a/src/core/common_code/internal/common_code.inl +++ b/src/core/common_code/internal/common_code.inl @@ -64,7 +64,7 @@ inline std::string CommonCode::to_string(const bool shorten) const { // ------------------------------------------------------------------------------------- // -inline std::optional CommonCode::from_string(const std::string &common_code) { +inline std::optional CommonCode::from_string(const std::string_view common_code) { return string_decode(common_code).transform(unsafe_create); } @@ -94,7 +94,7 @@ inline std::optional CommonCode::from_short_code(const uint32_t shor return ShortCode::create(short_code).transform(convert); } -inline std::optional CommonCode::from_short_code(const std::string &short_code) { +inline std::optional CommonCode::from_short_code(const std::string_view short_code) { const auto convert = [](const ShortCode code) { return code.to_common_code(); }; diff --git a/src/core/raw_code/internal/raw_code.inl b/src/core/raw_code/internal/raw_code.inl index 2037cdd..0ef5d10 100644 --- a/src/core/raw_code/internal/raw_code.inl +++ b/src/core/raw_code/internal/raw_code.inl @@ -50,7 +50,7 @@ inline std::optional RawCode::from_common_code(const uint64_t common_co return CommonCode::create(common_code).transform(convert); } -inline std::optional RawCode::from_common_code(const std::string &common_code) { +inline std::optional RawCode::from_common_code(const std::string_view common_code) { const auto convert = [](const CommonCode code) { return code.to_raw_code(); }; diff --git a/src/core/raw_code/raw_code.h b/src/core/raw_code/raw_code.h index ca4a37c..7f7d2f0 100644 --- a/src/core/raw_code/raw_code.h +++ b/src/core/raw_code/raw_code.h @@ -115,7 +115,7 @@ public: static std::optional from_common_code(uint64_t common_code); /// Create RawCode from CommonCode in string form. - static std::optional from_common_code(const std::string &common_code); + static std::optional from_common_code(std::string_view common_code); // ------------------------------------------------------------------------------------- // diff --git a/src/core/short_code/internal/short_code.inl b/src/core/short_code/internal/short_code.inl index 7807161..b12251c 100644 --- a/src/core/short_code/internal/short_code.inl +++ b/src/core/short_code/internal/short_code.inl @@ -73,7 +73,7 @@ inline CommonCode ShortCode::to_common_code() const { // ----------------------------------------------------------------------------------------- // -inline std::optional ShortCode::from_string(const std::string &short_code) { +inline std::optional ShortCode::from_string(const std::string_view short_code) { return string_decode(short_code).transform(unsafe_create); } @@ -90,7 +90,7 @@ inline std::optional ShortCode::from_common_code(const uint64_t commo return CommonCode::create(common_code).transform(convert); } -inline std::optional ShortCode::from_common_code(const std::string &common_code) { +inline std::optional ShortCode::from_common_code(const std::string_view common_code) { const auto convert = [](const CommonCode code) { return code.to_short_code(); }; diff --git a/src/core/short_code/short_code.h b/src/core/short_code/short_code.h index 0f8a366..20e95ef 100644 --- a/src/core/short_code/short_code.h +++ b/src/core/short_code/short_code.h @@ -126,7 +126,7 @@ public: // ------------------------------------------------------------------------------------- // /// Create ShortCode from string form. - static std::optional from_string(const std::string &short_code); + static std::optional from_string(std::string_view short_code); // ------------------------------------------------------------------------------------- // @@ -137,7 +137,7 @@ public: static std::optional from_common_code(uint64_t common_code); /// Create ShortCode from CommonCode in string form. - static std::optional from_common_code(const std::string &common_code); + static std::optional from_common_code(std::string_view common_code); // ------------------------------------------------------------------------------------- //