From fb804c214c865fd952fada3196d48399c67423ff Mon Sep 17 00:00:00 2001
From: Dnomd343 <i@343.re>
Date: Sat, 21 Jan 2023 00:23:36 +0800
Subject: [PATCH] perf: case graph render process

---
 src/graph/graph.cc | 78 ++++++++++------------------------------------
 1 file changed, 16 insertions(+), 62 deletions(-)

diff --git a/src/graph/graph.cc b/src/graph/graph.cc
index 0629ecf..985cca7 100644
--- a/src/graph/graph.cc
+++ b/src/graph/graph.cc
@@ -113,24 +113,17 @@ void Graph::svg_demo(Analyse::track_data_t track_data) {
 
     }
 
-    printf("</svg>\n");
-
 
 }
 
-//void SvgRect::to_xml() const {
-//    // TODO: return std::string
-//    printf(R"(<rect x="%ld" y="%ld" width="%ld" height="%ld" style="fill:pink;stroke-width:1;stroke:blue"/>)", left, top, width, height);
-//    printf("\n");
-//}
-
 void GraphCase::render(SvgGraph &svg, const CaseSkin &skin) const {
-//    std::cout << "render begin" << std::endl;
-
+    /// precompute size info
     auto raw_code = (uint64_t)code;
+    uint32_t block_width_2 = block_width * 2 + block_gap;
     uint32_t case_width = block_width * 4 + block_gap * 5;
     uint32_t case_height = block_width * 5 + block_gap * 6;
 
+    /// case skeleton render
     auto skeleton = new SvgRect {start, case_width, case_height};
     skeleton->color = skin.CASE_BG_COLOR;
     skeleton->stroke = skin.CASE_BORDER_WIDTH;
@@ -138,78 +131,39 @@ void GraphCase::render(SvgGraph &svg, const CaseSkin &skin) const {
     skeleton->radius = uint64_t(skin.CASE_RADIUS * (float)block_width);
     svg.insert(skeleton);
 
-    auto apply_skin = [&skin, this](SvgRect *block) {
+    /// lambda for insert new block
+    auto new_block = [this, &skin, &svg](SvgRect *block) {
         block->color = skin.BLOCK_BG_COLOR;
         block->stroke = skin.BLOCK_BORDER_WIDTH;
         block->line_color = skin.BLOCK_BORDER_COLOR;
         block->radius = uint64_t(skin.BLOCK_RADIUS * (float)block_width);
+        svg.insert(block);
     };
 
-    SvgRect *block;
-
     for (int addr = 0; raw_code; ++addr, raw_code >>= 3) {
+        /// calculate block address
         uint32_t block_x = addr % 4;
         uint32_t block_y = (addr - block_x) / 4;
-
-        // TODO: same start point
-
+        Point block_start = {
+            start.x + block_x * block_width + (block_x + 1) * block_gap,
+            start.y + block_y * block_width + (block_y + 1) * block_gap,
+        };
+        /// render into svg graph
         switch (raw_code & 0b111) {
             case B_1x1:
-
-                block = new SvgRect {
-                    {
-                        start.x + block_x * block_width + (block_x + 1) * block_gap,
-                        start.y + block_y * block_width + (block_y + 1) * block_gap,
-                    },
-                    block_width, block_width,
-                };
-                apply_skin(block);
-                svg.insert(block);
-
+                new_block(new SvgRect {block_start, block_width, block_width});
                 break;
             case B_1x2:
-
-                block = new SvgRect {
-                    {
-                        start.x + block_x * block_width + (block_x + 1) * block_gap,
-                        start.y + block_y * block_width + (block_y + 1) * block_gap,
-                    },
-                    block_width * 2 + block_gap, block_width,
-                };
-                apply_skin(block);
-                svg.insert(block);
-
+                new_block(new SvgRect {block_start, block_width_2, block_width});
                 break;
             case B_2x1:
-
-                block = new SvgRect {
-                    {
-                        start.x + block_x * block_width + (block_x + 1) * block_gap,
-                        start.y + block_y * block_width + (block_y + 1) * block_gap,
-                    },
-                    block_width, block_width * 2 + block_gap,
-                };
-                apply_skin(block);
-                svg.insert(block);
-
+                new_block(new SvgRect {block_start, block_width, block_width_2});
                 break;
             case B_2x2:
-
-                block = new SvgRect {
-                    {
-                        start.x + block_x * block_width + (block_x + 1) * block_gap,
-                        start.y + block_y * block_width + (block_y + 1) * block_gap,
-                    },
-                    block_width * 2 + block_gap, block_width * 2 + block_gap,
-                };
-                apply_skin(block);
-                svg.insert(block);
-
+                new_block(new SvgRect {block_start, block_width_2, block_width_2});
                 break;
             default:
                 continue;
         }
     }
-
-
 }