Do not return empty list if raise exception

8 years ago · e048e224d0
1 changed files with 4 additions and 5 deletions
--- a/db_transfer.py
+++ b/db_transfer.py
@ -314,8 +314,9 @@ class DbTransfer(TransferBase):
 		except Exception as e:
 			logging.error(e)
 			update_transfer = {}
-
+		finally:
 			conn.close()
+
 		return update_transfer

 	def pull_db_all_user(self):
@ -333,9 +334,7 @@ class DbTransfer(TransferBase):

 		try:
 			rows = self.pull_db_users(conn)
-		except Exception as e:
-			logging.error(e)
-			rows = []
+		finally:
 			conn.close()

 		if not rows: